Fix issue #26: P0 bug: run-qa-agent.sh and run-report-agent.sh don't build binary if missing#122
Closed
Fix issue #26: P0 bug: run-qa-agent.sh and run-report-agent.sh don't build binary if missing#122
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #26 by making the convenience scripts (run-qa-agent.sh, run-report-agent.sh) resilient on fresh clones by building the ./shellforge binary automatically when it’s missing, matching the behavior of scripts/run-agent.sh.
Changes:
- Added a build-if-missing guard (
go build -o shellforge ./cmd/shellforge) toscripts/run-qa-agent.sh. - Added the same build-if-missing guard to
scripts/run-report-agent.sh. - Added a helper script
outputs/test_fix.shthat checks for the presence of the new build logic.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| scripts/run-report-agent.sh | Builds ./shellforge automatically if missing before running report. |
| scripts/run-qa-agent.sh | Builds ./shellforge automatically if missing before running qa. |
| outputs/test_fix.sh | Adds a repo-check script intended to validate the fix via greps and syntax checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+48
| #!/usr/bin/env bash | ||
| set -euo pipefail | ||
|
|
||
| echo "Testing fix for issue #26: run-qa-agent.sh and run-report-agent.sh build binary if missing" | ||
| echo "================================================================================" | ||
|
|
||
| # Note: We can't use rm due to governance, so we'll test differently | ||
| echo "" | ||
| echo "Note: Due to governance restrictions, we can't remove the binary." | ||
| echo "Instead, we'll verify the build logic is present in the scripts." | ||
| echo "" | ||
|
|
||
| echo "1. Checking run-qa-agent.sh has build logic..." | ||
| if grep -q "Building shellforge" scripts/run-qa-agent.sh; then | ||
| echo "✓ run-qa-agent.sh has build logic" | ||
| else | ||
| echo "✗ run-qa-agent.sh missing build logic" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "" | ||
| echo "2. Checking run-report-agent.sh has build logic..." | ||
| if grep -q "Building shellforge" scripts/run-report-agent.sh; then | ||
| echo "✓ run-report-agent.sh has build logic" | ||
| else | ||
| echo "✗ run-report-agent.sh missing build logic" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "" | ||
| echo "3. Comparing with run-agent.sh (reference implementation)..." | ||
| if grep -q "if \[\[ ! -f ./shellforge \]\]" scripts/run-qa-agent.sh && \ | ||
| grep -q "if \[\[ ! -f ./shellforge \]\]" scripts/run-report-agent.sh; then | ||
| echo "✓ Both scripts have the same build pattern as run-agent.sh" | ||
| else | ||
| echo "✗ Build pattern doesn't match run-agent.sh" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "" | ||
| echo "4. Checking script syntax..." | ||
| bash -n scripts/run-qa-agent.sh && echo "✓ run-qa-agent.sh syntax OK" || exit 1 | ||
| bash -n scripts/run-report-agent.sh && echo "✓ run-report-agent.sh syntax OK" || exit 1 | ||
|
|
||
| echo "" | ||
| echo "================================================================================" | ||
| echo "All checks passed! The fix for issue #26 is implemented correctly." | ||
| echo "Both scripts now have the same build-if-missing logic as run-agent.sh." No newline at end of file |
There was a problem hiding this comment.
outputs/ is used by the app as a runtime artifact directory (e.g., cmd/shellforge/main.go creates outputs/logs and outputs/reports, and .gitignore marks these as generated). Committing outputs/test_fix.sh risks polluting agent workflows that scan outputs/ (e.g., the report agent prompt references reading logs from outputs/). Consider moving this check script under scripts/ or docs/, or deleting it if it’s not intended to ship with the repo.
Suggested change
| #!/usr/bin/env bash | |
| set -euo pipefail | |
| echo "Testing fix for issue #26: run-qa-agent.sh and run-report-agent.sh build binary if missing" | |
| echo "================================================================================" | |
| # Note: We can't use rm due to governance, so we'll test differently | |
| echo "" | |
| echo "Note: Due to governance restrictions, we can't remove the binary." | |
| echo "Instead, we'll verify the build logic is present in the scripts." | |
| echo "" | |
| echo "1. Checking run-qa-agent.sh has build logic..." | |
| if grep -q "Building shellforge" scripts/run-qa-agent.sh; then | |
| echo "✓ run-qa-agent.sh has build logic" | |
| else | |
| echo "✗ run-qa-agent.sh missing build logic" | |
| exit 1 | |
| fi | |
| echo "" | |
| echo "2. Checking run-report-agent.sh has build logic..." | |
| if grep -q "Building shellforge" scripts/run-report-agent.sh; then | |
| echo "✓ run-report-agent.sh has build logic" | |
| else | |
| echo "✗ run-report-agent.sh missing build logic" | |
| exit 1 | |
| fi | |
| echo "" | |
| echo "3. Comparing with run-agent.sh (reference implementation)..." | |
| if grep -q "if \[\[ ! -f ./shellforge \]\]" scripts/run-qa-agent.sh && \ | |
| grep -q "if \[\[ ! -f ./shellforge \]\]" scripts/run-report-agent.sh; then | |
| echo "✓ Both scripts have the same build pattern as run-agent.sh" | |
| else | |
| echo "✗ Build pattern doesn't match run-agent.sh" | |
| exit 1 | |
| fi | |
| echo "" | |
| echo "4. Checking script syntax..." | |
| bash -n scripts/run-qa-agent.sh && echo "✓ run-qa-agent.sh syntax OK" || exit 1 | |
| bash -n scripts/run-report-agent.sh && echo "✓ run-report-agent.sh syntax OK" || exit 1 | |
| echo "" | |
| echo "================================================================================" | |
| echo "All checks passed! The fix for issue #26 is implemented correctly." | |
| echo "Both scripts now have the same build-if-missing logic as run-agent.sh." |
Comment on lines
+5
to
10
| if [[ ! -f ./shellforge ]]; then | ||
| echo "[run-qa-agent] Building shellforge..." | ||
| go build -o shellforge ./cmd/shellforge | ||
| fi | ||
|
|
||
| exec ./shellforge qa "${1:-.}" |
There was a problem hiding this comment.
These scripts now duplicate the same “build-if-missing” logic that already exists in scripts/run-agent.sh. To avoid drift across scripts, consider delegating to scripts/run-agent.sh (e.g., exec scripts/run-agent.sh qa ...) so the build guard stays centralized.
Suggested change
| if [[ ! -f ./shellforge ]]; then | |
| echo "[run-qa-agent] Building shellforge..." | |
| go build -o shellforge ./cmd/shellforge | |
| fi | |
| exec ./shellforge qa "${1:-.}" | |
| exec scripts/run-agent.sh qa "${1:-.}" |
Comment on lines
+5
to
10
| if [[ ! -f ./shellforge ]]; then | ||
| echo "[run-report-agent] Building shellforge..." | ||
| go build -o shellforge ./cmd/shellforge | ||
| fi | ||
|
|
||
| exec ./shellforge report "${1:-.}" |
There was a problem hiding this comment.
These scripts now duplicate the same “build-if-missing” logic that already exists in scripts/run-agent.sh. To avoid drift across scripts, consider delegating to scripts/run-agent.sh (e.g., exec scripts/run-agent.sh report ...) so the build guard stays centralized.
Suggested change
| if [[ ! -f ./shellforge ]]; then | |
| echo "[run-report-agent] Building shellforge..." | |
| go build -o shellforge ./cmd/shellforge | |
| fi | |
| exec ./shellforge report "${1:-.}" | |
| exec scripts/run-agent.sh report "${1:-.}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated by Cata via /evolve dispatch
Task: brain-26-1775284345
Fixed issue #26 where run-qa-agent.sh and run-report-agent.sh would fail if the shellforge binary was missing. Added the same build logic that exists in run-agent.sh.